Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: Character set issues under Catalina #14763

Closed
ruudboon opened this issue Jan 23, 2020 · 6 comments
Closed

[BUG]: Character set issues under Catalina #14763

ruudboon opened this issue Jan 23, 2020 · 6 comments
Labels
bug A bug report status: low Low

Comments

@ruudboon
Copy link
Member

ruudboon commented Jan 23, 2020

Our Github runners run on the latest MacOS and show some issues with character conversion.
I was able to reproduce this on a local Mac as well.

https://github.com/phalcon/cphalcon/runs/404587405#step:12:76

Expecting that we need to look at ext/kernel/filter.c - zephir_escape_multi()
Can you have a look at this @sergeyklay ?

Phalcon 4.0.2 - PHP 7.2 / PHP 7.3 / PHP 7.4

@ruudboon
Copy link
Member Author

Steps to reproduce this. Run on MacOS Catalina with Phalcon 4.0.2

<?php

$source = 'émotion';
$expected = '\e9 motion';

$escaper = new \Phalcon\Escaper();
$result = $escaper->escapeCss($source);

echo "Source: " . $source . PHP_EOL;
echo "Expected: " . $expected . PHP_EOL;
echo "Result: " . $result . PHP_EOL;
if ($result != $expected) {
    echo "fail" . PHP_EOL;
} else {
    echo "ok" . PHP_EOL;
}

I think escapeCss is calling: https://github.com/phalcon/cphalcon/blob/master/ext/kernel/filter.c#L294

And then:
https://github.com/phalcon/cphalcon/blob/master/ext/kernel/filter.c#L149

@ruudboon ruudboon added the 4.0.3 label Jan 25, 2020
@ruudboon ruudboon added 4.0.4 and removed 4.0.3 labels Jan 25, 2020
@ruudboon
Copy link
Member Author

@ruudboon
Copy link
Member Author

ruudboon commented Feb 8, 2020

@sergeyklay Let's leave this for now. I think other issues are currently more important.

@ruudboon
Copy link
Member Author

This issue will be resolved with the next Zephir release. (0.12.17)

@sergeyklay
Copy link
Contributor

Zephir 0.12.17 released

@ruudboon
Copy link
Member Author

Fixed in 4.0.x

@niden niden moved this to Released in Phalcon v5 Aug 25, 2022
@niden niden added this to Phalcon v5 Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A bug report status: low Low
Projects
Archived in project
Development

No branches or pull requests

2 participants