T14733 Data Mapper PDO Connection #14824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niden
added
4.1.0
documentation
ruudboon
requested changes
Feb 8, 2020
phalcon/DM/Pdo/Connection.zep
Outdated
|
|
||
| if !this->pdo { | ||
| // connect | ||
| this->profiler->start(__FUNCTION__); |
There was a problem hiding this comment.
Can we make the profiler optional for perfomance?
There was a problem hiding this comment.
The if statement is in the Profiler class (active). It was a tradeoff between putting if statements in every fetch method and not having one method call vs. having the method call and the if is in the profiler.
phalcon/DM/Pdo/Connection.zep
Outdated
| * @license https://github.com/atlasphp/Atlas.Pdo/blob/1.x/LICENSE.md | ||
| */ | ||
|
|
||
| namespace Phalcon\DM\Pdo; |
There was a problem hiding this comment.
I think the the DM can be a bit confusing. This could also be Device management, Device mapper, Distributed Mama's ;) etc. Can we just name it DataMapper? It isn't super long, and I don't see the advantages of abbreviation here.
ruudboon
approved these changes
Feb 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
In raising this pull request, I confirm the following:
Added new PDO wrapper for the Data Mapper implementation, with decorated instance, locator and profiler
DM\ConnectionDM\Connection\DecoratedDM\Profiler\ProfilerDM\Profiler\MemoryLoggerDM\ConnectionLocatorThis component will be used in the Data Mapper implementation but can be used as a stand alone component for PDO connections.
Thanks