Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

T13297 datetime fraction #14654

Merged
merged 31 commits into from
Dec 24, 2019
Merged

T13297 datetime fraction #14654

merged 31 commits into from
Dec 24, 2019

Conversation

niden
Copy link
Member

@niden niden commented Dec 24, 2019

Hello!

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR
  • I have updated the relevant CHANGELOG
  • I have created a PR for the documentation about this change

Fixed Phalcon\Db\Dialect\Mysql::getColumnDefinition to recognize size for DATETIME, TIME and TIMESTAMP columns

Thanks

@niden niden added bug A bug report 4.1 status: medium Medium labels Dec 24, 2019
@codecov
Copy link

codecov bot commented Dec 24, 2019

Codecov Report

Merging #14654 into 4.1.x will increase coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##            4.1.x   #14654      +/-   ##
==========================================
+ Coverage   67.46%   67.47%   +<.01%     
==========================================
  Files         483      483              
  Lines      111367   111391      +24     
==========================================
+ Hits        75139    75166      +27     
+ Misses      36228    36225       -3

CHANGELOG-4.0.md Outdated Show resolved Hide resolved
@niden niden merged commit b64265f into phalcon:4.1.x Dec 24, 2019
@niden niden deleted the T13297-datetime-fraction branch December 24, 2019 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A bug report status: medium Medium
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants