Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NFR] Allow size parameter for datetime and timestamp columns #13297

Closed
robin-rozo opened this issue Feb 9, 2018 · 3 comments
Closed

[NFR] Allow size parameter for datetime and timestamp columns #13297

robin-rozo opened this issue Feb 9, 2018 · 3 comments
Assignees
@niden
Labels
bug A bug report status: medium Medium

Comments

@robin-rozo
Copy link

When I want to add a size parameter to a column definition, the size is not added in the generated query. This size is mandatory in MySQL to create columns with fractionnal time values see doc.
@sergeyklay sergeyklay self-assigned this Feb 13, 2018
@sergeyklay sergeyklay added the enhancement Enhancement to the framework label Feb 13, 2018
@stale stale bot added the stale Stale issue - automatically closed label May 14, 2018
@stale stale bot closed this as completed May 15, 2018
@sergeyklay sergeyklay reopened this May 16, 2018
@stale stale bot removed the stale Stale issue - automatically closed label May 16, 2018
@sergeyklay sergeyklay added this to the 4.0.0 milestone May 16, 2018
@sergeyklay sergeyklay added New Feature Request and removed enhancement Enhancement to the framework labels May 16, 2018
@phalcon phalcon deleted a comment from stale bot Feb 21, 2019
@niden niden mentioned this issue Feb 23, 2019
Closed
@ruudboon ruudboon removed this from the 4.0.0 milestone Sep 21, 2019
@niden niden added 4.1 bug A bug report status: medium Medium and removed Bug - Medium labels Dec 21, 2019
@niden
Copy link
Member

niden commented Dec 24, 2019

@robin-rozo Do you happen to have an example or a small code snippet handy?

@niden
Copy link
Member

niden commented Dec 24, 2019

Actually I think I got it.

@niden niden mentioned this issue Dec 24, 2019
Merged
5 tasks
@sergeyklay sergeyklay removed their assignment Dec 24, 2019
niden added a commit that referenced this issue Dec 24, 2019
@niden
Merge branch 'T13297-datetime-fraction' of https://github.com/niden/c…
04eee86 
…phalcon into niden-T13297-datetime-fraction

* 'T13297-datetime-fraction' of https://github.com/niden/cphalcon: (31 commits)
  [#13297] - Updated changelog again
  [#13297] - Changelog update again
  [#13297] - Updated the changelog
  [#13297] - Added new section for 4.1
  [#13297] - Updated changelog
  [#13297] - Corrected the logic for the dialect
  [#13297] - Added size to datetime/time and timestamp fields
  [#13297] - Added test with fractal fields
  [#13297] - Added new migration and table
  [#13856] - Another correction
  [#13856] - Corrected variable name
  [#13856] - Minor changes (restructured getters) based on review
  [#13856] - PHPCS
  [#13856] - Corrected validating signature method
  [#13856] - Correcting tests
  [#13856] - Removed tests out of place
  [#13856] - PHPCS
  [#13856] - Added tests for JWT
  [#13856] - Added Base64 helper
  [#13856] - Added Base64 helper and minor correction to audience (builder)
  ...
niden added a commit that referenced this issue Dec 24, 2019
@niden
Merge branch 'niden-T13297-datetime-fraction' into 4.1.x
484cfd9 
* niden-T13297-datetime-fraction: (31 commits)
  [#13297] - Updated changelog again
  [#13297] - Changelog update again
  [#13297] - Updated the changelog
  [#13297] - Added new section for 4.1
  [#13297] - Updated changelog
  [#13297] - Corrected the logic for the dialect
  [#13297] - Added size to datetime/time and timestamp fields
  [#13297] - Added test with fractal fields
  [#13297] - Added new migration and table
  [#13856] - Another correction
  [#13856] - Corrected variable name
  [#13856] - Minor changes (restructured getters) based on review
  [#13856] - PHPCS
  [#13856] - Corrected validating signature method
  [#13856] - Correcting tests
  [#13856] - Removed tests out of place
  [#13856] - PHPCS
  [#13856] - Added tests for JWT
  [#13856] - Added Base64 helper
  [#13856] - Added Base64 helper and minor correction to audience (builder)
  ...
@niden
Copy link
Member

niden commented Dec 24, 2019

Resolved in #14654

@niden niden closed this as completed Dec 24, 2019
@niden niden self-assigned this Dec 25, 2019
niden added a commit that referenced this issue Feb 4, 2020
@niden
[#13297] - Added new migration and table
963584a
niden added a commit that referenced this issue Feb 4, 2020
@niden
[#13297] - Added test with fractal fields
3e8a21c
niden added a commit that referenced this issue Feb 4, 2020
@niden
[#13297] - Added size to datetime/time and timestamp fields
1174583
niden added a commit that referenced this issue Feb 4, 2020
@niden
[#13297] - Corrected the logic for the dialect
eee7793
niden added a commit that referenced this issue Feb 4, 2020
@niden
[#13297] - Updated changelog
d2900e5
niden added a commit that referenced this issue Feb 4, 2020
@niden
[#13297] - Updated the changelog
36e1328
niden added a commit that referenced this issue Feb 4, 2020
@niden
[#13297] - Changelog update again
2716780
niden added a commit that referenced this issue Feb 4, 2020
@niden
[#13297] - Updated changelog again
f6194b5
@niden niden moved this to Released in Phalcon v5 Aug 25, 2022
@niden niden added this to Phalcon v5 Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@niden niden

Labels
bug A bug report status: medium Medium
Projects
Phalcon v5
Archived in project
Milestone
No milestone
Development

No branches or pull requests
4 participants
@niden @sergeyklay @robin-rozo @ruudboon