Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

T14553 escaper nulls #14554

Merged
merged 2 commits into from
Nov 22, 2019
Merged

T14553 escaper nulls #14554

merged 2 commits into from
Nov 22, 2019

Conversation

niden
Copy link
Member

@niden niden commented Nov 22, 2019

Hello!

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR
  • I have updated the relevant CHANGELOG
  • I have created a PR for the documentation about this change

Fixed Phalcon\Escaper::escapeHtml and Phalcon\Escaper::escapeHtmlAttr to allow null values

Thanks

@niden niden changed the base branch from master to 4.0.x November 22, 2019 18:14
Copy link
Member

@ruudboon ruudboon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. thnx

@codecov
Copy link

codecov bot commented Nov 22, 2019

Codecov Report

Merging #14554 into 4.0.x will decrease coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##            4.0.x   #14554      +/-   ##
==========================================
- Coverage   67.73%   67.73%   -0.01%     
==========================================
  Files         488      488              
  Lines      112556   112562       +6     
==========================================
+ Hits        76245    76247       +2     
- Misses      36311    36315       +4

@niden niden merged commit 6122d1f into phalcon:4.0.x Nov 22, 2019
@niden niden deleted the T14553-escaper-nulls branch November 22, 2019 18:54
@niden niden added bug A bug report status: low Low and removed Bug - Low labels Dec 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A bug report status: low Low
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants