Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG/REGRESSION]: Phalcon\Escaper::escapeHtml() no longer accepts null in v4 #14553

Closed
terax6669 opened this issue Nov 22, 2019 · 1 comment
Closed
Labels
bug A bug report status: low Low

Comments

@terax6669
Copy link

Describe the bug
v4 compiled with Zephir 0.12.x no longer allows to pass null to the method.

To Reproduce

{{ request.getPost('email') | e }}

Steps to reproduce the behavior:

Use the above piece of code in volt view on a GET request.

Expected behavior
When null is passed to the Escaper it returns null or empty string back to the view.

Screenshots
image

Details

  • Phalcon version: 4.0.0-rc3
  • PHP Version: 7.2
  • Operating System: Debian
  • Installation type: packagecloud.io
  • Server: Nginx
@niden niden mentioned this issue Nov 22, 2019
5 tasks
niden added a commit that referenced this issue Nov 22, 2019
niden added a commit that referenced this issue Nov 22, 2019
@niden
Copy link
Member

niden commented Nov 22, 2019

Resolved in #14554

Thank you @terax6669

@niden niden closed this as completed Nov 22, 2019
@niden niden added bug A bug report status: low Low and removed Bug - Low labels Dec 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A bug report status: low Low
Projects
None yet
Development

No branches or pull requests

2 participants