Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 14386 #14387

Merged
merged 3 commits into from
Sep 16, 2019
Merged

Issue 14386 #14387

merged 3 commits into from
Sep 16, 2019

Conversation

ruudboon
Copy link
Member

@ruudboon ruudboon commented Sep 16, 2019

Hello!

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR
  • I have updated the relevant CHANGELOG
  • I have created a PR for the documentation about this change

Changed order of properties

@niden
Copy link
Member

niden commented Sep 16, 2019

@ruudboon If it is not too much trouble can you also update upgrade.md in docs regarding this? I will sort out the API generation in the next docs deployment

@niden niden added 4.0 enhancement Enhancement to the framework labels Sep 16, 2019
@ruudboon
Copy link
Member Author

@ruudboon If it is not too much trouble can you also update upgrade.md in docs regarding this? I will sort out the API generation in the next docs deployment

phalcon-orphanage/docs#2430

@ruudboon ruudboon merged commit fc40a40 into phalcon:4.0.x Sep 16, 2019
@codecov
Copy link

codecov bot commented Sep 16, 2019

Codecov Report

Merging #14387 into 4.0.x will increase coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##            4.0.x   #14387      +/-   ##
==========================================
+ Coverage   67.63%   67.63%   +<.01%     
==========================================
  Files         478      478              
  Lines      110975   110977       +2     
==========================================
+ Hits        75056    75058       +2     
  Misses      35919    35919

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement to the framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants