Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RFC] Change property order in model->assign() #14386

Closed
ruudboon opened this issue Sep 16, 2019 · 1 comment
Closed

[RFC] Change property order in model->assign() #14386

ruudboon opened this issue Sep 16, 2019 · 1 comment
Assignees
@ruudboon
Labels
enhancement Enhancement to the framework

Comments

@ruudboon
Copy link
Member

Our current implementation looks like this:

assign(array $data, [mixed $dataColumnMap], [array $whiteList])

Often you will setup the column map in the model and don't specify it when assigning data to the model. When using the whitelist you should always put null on the dataColumnMap.
It would be me more logical to have the whitelist first.

assign(array $data, [array $whiteList], [mixed $dataColumnMap])
@ruudboon ruudboon added enhancement Enhancement to the framework 4.0 labels Sep 16, 2019
@ruudboon ruudboon self-assigned this Sep 16, 2019
This was referenced Sep 16, 2019
Merged
Merged
niden pushed a commit to phalcon-orphanage/docs that referenced this issue Sep 16, 2019
@ruudboon @niden
Added assign parameter change. See phalcon/cphalcon#14386 (#2430)
508f4e0
@niden
Copy link
Member

niden commented Sep 16, 2019

Resolved

@niden niden closed this as completed Sep 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ruudboon ruudboon

Labels
enhancement Enhancement to the framework
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@niden @ruudboon