Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add persistent id for Redis pconnect() method. #14335

Closed
wants to merge 7 commits into from

Conversation

lanlin
Copy link
Contributor

@lanlin lanlin commented Aug 27, 2019

we'd better have a persistent id for Redis pconnect() method.
cause without it we can't switch between multiple databases at in the same PHP process.
the data will always be saved to the last database without it.
as I know all Phalcon versions have this bug.

check this: https://github.com/phpredis/phpredis#pconnect-popen

sergeyklay
sergeyklay previously approved these changes Aug 27, 2019
Copy link
Contributor

@Jurigag Jurigag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change branch, we don't accept prs to master branch.

phalcon/Storage/Adapter/Redis.zep Outdated Show resolved Hide resolved
phalcon/Storage/Adapter/Redis.zep Outdated Show resolved Hide resolved
@niden
Copy link
Member

niden commented Aug 27, 2019

Also please target the 4.x branch and update the changelog. After that this is good to go.

@codecov
Copy link

codecov bot commented Aug 27, 2019

Codecov Report

Merging #14335 into 4.0.x will increase coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##            4.0.x   #14335      +/-   ##
==========================================
+ Coverage    66.3%   66.31%   +<.01%     
==========================================
  Files         488      488              
  Lines      115903   115905       +2     
==========================================
+ Hits        76855    76857       +2     
  Misses      39048    39048

Copy link
Member

@ruudboon ruudboon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update the CHANGELOG-4.0.md also?

@lanlin lanlin changed the base branch from master to 4.0.x August 28, 2019 01:20
issue phalcon#14334

1. update changelog-4.0.md
2.ignore .idea
3. modified method `getAdapter()` in redis adapter
@lanlin
Copy link
Contributor Author

lanlin commented Aug 28, 2019

Change branch, we don't accept prs to master branch.
Also please target the 4.x branch and update the changelog. After that this is good to go.
Can you update the CHANGELOG-4.0.md also?

@niden @ruudboon @Jurigag the above changes have been modified. there anything else?

@CameronHall
Copy link
Contributor

@lanlin, you have a lot of commits in your PR that aren't relevant. Can you please only send the relevant commits?

@lanlin
Copy link
Contributor Author

lanlin commented Aug 28, 2019

sorry,i based on a wrong branch, let me create a new pull.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants