-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add persistent id for Redis pconnect()
method.
#14335
Conversation
4.0.0-alpha.5
4.0.0-beta.1
v4.0.0-beta.2
add persistent id for Redis `pconnect()` method.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change branch, we don't accept prs to master branch.
Also please target the 4.x branch and update the changelog. After that this is good to go. |
Codecov Report
@@ Coverage Diff @@
## 4.0.x #14335 +/- ##
==========================================
+ Coverage 66.3% 66.31% +<.01%
==========================================
Files 488 488
Lines 115903 115905 +2
==========================================
+ Hits 76855 76857 +2
Misses 39048 39048 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you update the CHANGELOG-4.0.md also?
issue phalcon#14334 1. update changelog-4.0.md 2.ignore .idea 3. modified method `getAdapter()` in redis adapter
@lanlin, you have a lot of commits in your PR that aren't relevant. Can you please only send the relevant commits? |
sorry,i based on a wrong branch, let me create a new pull. |
we'd better have a persistent id for Redis pconnect() method.
cause without it we can't switch between multiple databases at in the same PHP process.
the data will always be saved to the last database without it.
as I know all Phalcon versions have this bug.
check this: https://github.com/phpredis/phpredis#pconnect-popen