Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

provide a persistent id for redis persistent connection #14334

Closed
lanlin opened this issue Aug 27, 2019 · 1 comment
Closed

provide a persistent id for redis persistent connection #14334

lanlin opened this issue Aug 27, 2019 · 1 comment
Labels
new feature request Planned Feature or New Feature Request

Comments

@lanlin
Copy link
Contributor

lanlin commented Aug 27, 2019 •
edited
Loading

Description

we'd better provide a persistent id for Redis pconnect() method.

cause without it we can't switch between multiple databases in the same PHP process.

the data will always be saved to the last database without it.

as I know all Phalcon versions have this bug.

check this: https://github.com/phpredis/phpredis#pconnect-popen

Details

image
lanlin referenced this issue Aug 27, 2019
@lanlin
update redis adapter persistent method
856dd1c 
 add persistent id for Redis `pconnect()` method.
@Jurigag Jurigag added enhancement Enhancement to the framework 4.1 new feature request Planned Feature or New Feature Request and removed enhancement Enhancement to the framework labels Aug 27, 2019
@lanlin lanlin mentioned this issue Aug 27, 2019
Closed
lanlin added a commit to lanlin/cphalcon that referenced this issue Aug 28, 2019
@lanlin
issue phalcon#14334 update
8b3b9b2 
issue phalcon#14334

1. update changelog-4.0.md
2.ignore .idea
3. modified method `getAdapter()` in redis adapter
@lanlin lanlin mentioned this issue Aug 28, 2019
Merged
@niden niden added 4.0 and removed 4.1 labels Nov 3, 2019
@niden
Copy link
Member

niden commented Nov 3, 2019

Implemented

@niden niden closed this as completed Nov 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
new feature request Planned Feature or New Feature Request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@niden @lanlin @Jurigag