Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #14198: Missing validation value resolution #14200

Merged
merged 1 commit into from
Jun 23, 2019

Conversation

CameronHall
Copy link
Contributor

@CameronHall CameronHall commented Jun 23, 2019

Hello!

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR
  • I have updated the relevant CHANGELOG
  • I have created a PR for the documentation about this change-

Small description of the change:

let value = validation->getValue(field);

Thanks

@codecov
Copy link

codecov bot commented Jun 23, 2019

Codecov Report

Merging #14200 into 4.0.x will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##            4.0.x   #14200   +/-   ##
=======================================
  Coverage   66.31%   66.31%           
=======================================
  Files         475      475           
  Lines      111700   111700           
=======================================
  Hits        74078    74078           
  Misses      37622    37622

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a32421...9fa404d. Read the comment docs.

@sergeyklay sergeyklay merged commit 95d3d81 into phalcon:4.0.x Jun 23, 2019
@sergeyklay
Copy link
Contributor

Thank you

@niden niden added 4.0 labels Jun 23, 2019
@CameronHall CameronHall deleted the bugfix/T14198 branch October 24, 2019 11:36
@niden niden added bug A bug report status: low Low and removed Bug - Low labels Dec 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A bug report status: low Low
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants