Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invalid logic in Validator/File/FileAbstract #14198

Closed
ekmst opened this issue Jun 21, 2019 · 1 comment
Closed

Invalid logic in Validator/File/FileAbstract #14198

ekmst opened this issue Jun 21, 2019 · 1 comment
Labels
bug A bug report status: low Low

Comments

@ekmst
Copy link
Contributor

ekmst commented Jun 21, 2019 •
edited
Loading

Missed getting value from validation in methods:

Validator/File/FileAbstract::checkUploadIsEmpty()

Validator/File/FileAbstract::checkUploadIsValid()

I think should be add:

let value = validation->getValue(field);

@emiliodeg
CameronHall added a commit to CameronHall/cphalcon that referenced this issue Jun 23, 2019
@CameronHall
Fixed phalcon#14198: Missing validation value resolution
9fa404d
@CameronHall CameronHall mentioned this issue Jun 23, 2019
Merged
5 tasks
sergeyklay pushed a commit that referenced this issue Jun 23, 2019
@CameronHall @sergeyklay
Fixed #14198: Missing validation value resolution
95d3d81
@sergeyklay
Copy link
Contributor

Fixed in the 4.o.x branch. Thank you for contributing.

@niden niden added the 4.0 label Jun 23, 2019
@niden niden added bug A bug report status: low Low and removed Bug - Low labels Dec 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug A bug report status: low Low
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@niden @sergeyklay @ekmst