Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

T13548 validator url #14057

Merged
merged 7 commits into from
May 14, 2019
Merged

T13548 validator url #14057

merged 7 commits into from
May 14, 2019

Conversation

niden
Copy link
Member

@niden niden commented May 10, 2019

Hello!

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR
  • I updated the CHANGELOG

Changed Phalcon\Validation\Validator\Url to work with options in passed options. (FILTER_FLAG_PATH_REQUIRED, FILTER_FLAG_QUERY_REQUIRED)

Thanks

@niden niden added the enhancement Enhancement to the framework label May 10, 2019
@niden
Copy link
Member Author

niden commented May 10, 2019

cc @sergeyklay

@niden niden added the documentation Documentation required label May 12, 2019
@codecov
Copy link

codecov bot commented May 12, 2019

Codecov Report

Merging #14057 into 4.0.x will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##            4.0.x   #14057      +/-   ##
==========================================
+ Coverage   70.74%   70.75%   +<.01%     
==========================================
  Files         479      479              
  Lines       93803    93812       +9     
==========================================
+ Hits        66364    66373       +9     
  Misses      27439    27439
Impacted Files Coverage Δ
ext/phalcon/validation/validator/url.zep.c 100% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f723e1...6fea50e. Read the comment docs.

CHANGELOG-4.0.md Outdated Show resolved Hide resolved
sergeyklay
sergeyklay previously approved these changes May 14, 2019
@niden niden merged commit cfbf073 into phalcon:4.0.x May 14, 2019
@niden niden deleted the T13548-validator-url branch May 19, 2019 02:58
@niden niden added the 4.0 label Dec 2, 2019
@niden niden removed the documentation Documentation required label Dec 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement to the framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants