-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Phalcon\Validation\Validator\Url improvement #13548
Labels
enhancement
Enhancement to the framework
Milestone
Comments
niden
added a commit
that referenced
this issue
May 14, 2019
niden
added a commit
that referenced
this issue
May 14, 2019
niden
added a commit
that referenced
this issue
May 14, 2019
niden
added a commit
that referenced
this issue
May 14, 2019
Resolved in #14057 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I think this validator should accept flags.
FILTER_FLAG_SCHEME_REQUIREDFILTER_VALIDATE_URLRequires the URL to contain a scheme part.deprecatedFILTER_FLAG_HOST_REQUIREDFILTER_VALIDATE_URLRequires the URL to contain a host part.deprecatedActually given that those two flags had no effect since 5.x.x maybe we should consider custom URL validator because
filter_var
sucks. We need more control, like whether or not to consider protocol for an example. Or simply ditch Url altogether and use Regex...The text was updated successfully, but these errors were encountered: