Security Token Retention [PR#12518] and Fixed Security Tests #13642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niden
requested changes
Dec 8, 2018
CameronHall
force-pushed
the
feature/security-token-retention
branch
from
b74e134 to
3647da2
Compare
…ate fields after regenerating the token. Added string casting to userToken. Conflicts: CHANGELOG.md tests/unit/SecurityTest.php
Trying to append an element to an undefined variable (as demonstrated in the example below) will generate a segmentation fault. ```zep _SESSION['key'] = 'value'; ``` `$_SESSION` isn't available in the PHP CLI so we need to define it ourselves in `SecurityCest:_before`
CameronHall
force-pushed
the
feature/security-token-retention
branch
from
3647da2 to
5f0faae
Compare
|
All done @niden |
niden
approved these changes
Dec 8, 2018
|
Thank you! |
3 tasks
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
In raising this pull request, I confirm the following (please check boxes):
Small description of change: Created a retainer for the current session token in order to not break checkToken functionality if getToken is called before. Also fixed the security tests segmentation faults.
Thanks