Added retainer for current session token in order to not break checkToken functionality if getToken is called before. #12518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jurigag
suggested changes
Dec 29, 2016
gguridi
force-pushed
the
feature/security-retaining-session-for-checking
branch
from
56a0b1d to
9f27773
Compare
sergeyklay
suggested changes
Jan 3, 2017
There was a problem hiding this comment.
@gguridi We use the 3.0.x branch for bug fixes that do not break backward compatibility. I changed the base branch to 3.0.x from 3.1.x. But now your PR has conflicts that must be resolved. So could you please rebase the PR onto 3.0.x branch?
…ate fields after regenerating the token. Added string casting to userToken.
gguridi
force-pushed
the
feature/security-retaining-session-for-checking
branch
from
9f27773 to
28e2c44
Compare
Closed
sergeyklay
force-pushed
the
3.2.x
branch
2 times, most recently
from
e63249b to
821011d
Compare
sergeyklay
force-pushed
the
3.2.x
branch
2 times, most recently
from
14919a9 to
13ce09f
Compare
3 tasks
|
This has been implemented with PR #13642 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
In raising this pull request, I confirm the following (please check boxes):
Small description of change:
Security::checkToken functionality doesn't use the regenerated session but uses the one that was set at the beginning if it existed. This will prevent that if we call getToken and the session token is regenerated, the checkToken method will fail because the session token has changed.
I've also cast to string the userToken coming from the request::getPost method as it could be null and I was receiving an E_WARNING when passing it to hash_equals.
Thanks
This change is