T13114 message interfaces #13534
Merged
T13114 message interfaces #13534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Corrected use reference
|
How about #13113? |
|
@grigoriy-ivanov Missed that. I will update the PR accordingly today |
|
cc @sergeyklay |
|
@grigoriy-ivanov Just added the JsonSerializable |
|
Thank you, @niden |
* 4.0.x: [#13468] - Added `getHandlerSuffix()`, `setHandlerSuffix()` in Dispatcher, `getTaskSuffix()`, `setTaskSuffix()` in the CLI Dispatcher [#13529] - Moved the sharedLock in the dialects. PostgreSql and Sqlite return the original query Added entry in the changelog Corrected Message Correcte test Corrected call to getTemplate; removed unused variables Test corrections Correction in variables Removed unused variable; Corrected variable name Minor refactor of the escaping and html message Added custom template in prepareHtml Alpha sort of methods
…om/niden/cphalcon into T13114-message-interfaces * 'T13114-message-interfaces' of git://github.com/niden/cphalcon:
* 4.0.x: [4.0.x] - Removed duplicate method
sergeyklay
added
new feature request
Closed
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
In raising this pull request, I confirm the following (please check boxes):
Removed the
Messageinterfaces in validation and model. Added a new component/interfacePhalcon\Messages\MessageInterfacethat both model and validation use now. Did the same for the collection of messages.Thanks