Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NFR] JsonSerializable for all Message classes #13113

Closed
grigoriy-ivanov opened this issue Oct 8, 2017 · 3 comments
Closed

[NFR] JsonSerializable for all Message classes #13113

grigoriy-ivanov opened this issue Oct 8, 2017 · 3 comments
Assignees
Labels
stale Stale issue - automatically closed

Comments

@grigoriy-ivanov
Copy link

It will make code more simple when we are sending json response.
At the moment:

$messages = $robot->getMessages();
foreach ($messages as $message) {
    $response[] = $message->getText();
 }
$request->setJsonContent($response);

I would like to:

$messages = $robot->getMessages();
$request->setJsonContent($messages);

P.S. Phalcon has two different MessageInterfaces. Maybe should are be merged into one?

@sergeyklay
Copy link
Contributor

sergeyklay commented Oct 8, 2017

Could you please open a separated issue related to the MessageInterface

@grigoriy-ivanov
Copy link
Author

Yes. of course. #13114

@stale
Copy link

stale bot commented Apr 16, 2018

Thank you for contributing to this issue. As it has been 90 days since the last activity, we are automatically closing the issue. This is often because the request was already solved in some way and it just wasn't updated or it's no longer applicable. If that's not the case, please feel free to either reopen this issue or open a new one. We will be more than happy to look at it again! You can read more here: https://blog.phalconphp.com/post/github-closing-old-issues

@stale stale bot added the stale Stale issue - automatically closed label Apr 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale Stale issue - automatically closed
Projects
None yet
Development

No branches or pull requests

2 participants