Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify Redis Backend #11125

Closed
wants to merge 88 commits into from
Closed

Modify Redis Backend #11125

wants to merge 88 commits into from

Conversation

pantaovay
Copy link

Changes

  1. Modify cache redis backend, delete _PHCR
  2. Cache redis backend supports "redis" client option

Why

  1. The redis cache backend use a special key _PHCR to store all keys used by cache. There is a issue: why the backend cache redis add the special key(statsKey) _PHCR #10905 .According to @Green-Cat ,it is disabled in 2.0.x branch which is not true. If use _PHCR, every time we set a cache, we have to run sAdd and set commands. Store all keys in _PHCR will cause it expands quickly and this will influence performance.
  2. The libmemecached backend has supplied the option to disable this feature.
  3. The cache backend doesn't support redis option which means that we can not pass a redis connection. So if we use modelsCache and modelsMetadata, there will be two redis connections. So I modify this part and let redis option be supported, and through the lifetime of a request we can use one redis connection.

Andrew Mason and others added 30 commits April 21, 2015 23:49
column[0] can be undefined
31bb51a
MySQL has a double type which has a scale
3db24f3
@andresgutierrez
Merge pull request phalcon#10119 from masenocturnal/master
874c47d 
Check array key exists before accessing. Support mysql double column types
@agim-a
Fixed checking case insensitive image extensions
6c5967f 
Replaced strcmp with strcasecmp for checking image extenstions
@agim-a
Updated security.zep with fixes and new functionality
4739c29 
*checkToken* function makes sure that tokenKey exists in session if not provide


Added a utility function *destroyToken to be used when checkToken
returns true

Added a 3rd variable to *checkToken*
destroyIfValid, which removes token key and value from session

Moved token key and value session ids as protected properties
@agim-a
Update security.zep
0529628 
defined returnValue variable
@agim-a
Merge pull request phalcon#2 from agim-alb/agim-alb-patch-2
9907ca6 
Update security.zep
@agim-a
isLegacyHash
62754bd 
 isLegacyHash should return TRUE if the provided hash is not a bcrypt hash (instead of false)

No need for first argument password, since only hash is checked
@agim-a
Changed strcasecmp to using strtolower. Fixed bug with imagepng for p…
0622910 
…ng images (was imagejpeg)
@andresgutierrez
Merge pull request phalcon#10142 from agim-alb/patch-2
f22e54d 
Updated security.zep with fixes and new functionality
@andresgutierrez
Revert "Updated security.zep with fixes and new functionality"
501eaf6
@andresgutierrez
Merge pull request phalcon#10164 from phalcon/revert-10142-patch-2
e93893f 
Revert "Updated security.zep with fixes and new functionality"
@andresgutierrez
Merge pull request phalcon#10141 from agim-alb/patch-1
c4a3da5 
Fixed checking case insensitive image extensions
@andresgutierrez
Revert "Fixed checking case insensitive image extensions"
cd8f5f7
@andresgutierrez
Merge pull request phalcon#10171 from phalcon/revert-10141-patch-1
95d03ad 
Revert "Fixed checking case insensitive image extensions"
@andresgutierrez
Merge branch 'master' into 2.0.x
44da535
@andresgutierrez
Merge branch '2.0.x'
ad62026
@andresgutierrez
Merge pull request phalcon#10247 from phalcon/2.0.x
234dce9 
2.0.x
@endeveit
Fix "Wrong number of parameters" exception in Phalcon\Mvc\Collection\…
5508906 
…Manager
Merge pull request phalcon#10308 from endeveit/master
a3db77a 
[2.0.x] Fix "Wrong number of parameters" collection manager
@andresgutierrez
Revert "[2.0.x] Fix "Wrong number of parameters" collection manager"
70e338f
@andresgutierrez
Merge pull request phalcon#10309 from phalcon/revert-10308-master
df31130 
Revert "[2.0.x] Fix "Wrong number of parameters" collection manager"
@andresgutierrez
Merge pull request phalcon#10393 from phalcon/2.0.x
3070344 
2.0.2
@andresgutierrez
Merge pull request phalcon#10402 from phalcon/2.0.x
c705e11 
2.0.x
@andresgutierrez
Merge pull request phalcon#10488 from phalcon/2.0.x
c967827 
2.0.3
@andresgutierrez
Merge pull request phalcon#10493 from phalcon/2.0.x
b922cca 
2.0.3 [2]
@niden
Update CHANGELOG.md
a1e0752
@andresgutierrez
Merge branch 'master' into 2.0.x
f8cb2c1
@andresgutierrez
Merge branch '2.0.x'
e0c2afd
@andresgutierrez
Merge pull request phalcon#10599 from phalcon/2.0.x
02e7b82 
2.0.x
sergeyklay and others added 25 commits November 12, 2015 14:18
@sergeyklay @pantaovay
Amended Router Mvc Test
ff40314
@sergeyklay @pantaovay
Small fixes in Sqlite::describeIndexes
7f264a7
@sergeyklay @pantaovay
Fixed issue phalcon#11036
aaf3f55
@sergeyklay @pantaovay
Added tests for MySQL indexes
fffbede
@sergeyklay @pantaovay
Updated CHANGELOG
63d96d4
@SidRoberts @pantaovay
Fixed typo in Db\Dialect (filed -> field).
34e37a4
@SidRoberts @pantaovay
Removed redundant type-checking code from `Db\Dialect::getSqlExpressi…
5a28c3e 
…onHaving()`.
@SidRoberts @pantaovay
Added another example to Mvc\Url::get() (phalcon-orphanage/docs#432)
5e14667
@SidRoberts @pantaovay
Added stricter type-checking to Db\Dialect::getSqlExpressionHaving().
41e88ff
@ashpumpkin @pantaovay
Fixed notice in query builder paginator when totalQuery result is empty
924932e
@sergeyklay @pantaovay
Update Phalcon\Queue\Beanstalk\Job doc for getters
b045a1f
@sergeyklay @pantaovay
Added missed RouteInterface::setHostname, RouteInterface::getHostname
2b38bd5
@sergeyklay @pantaovay
Fixed Filter::sanitize return type
a5cc0dd
@sergeyklay @pantaovay
Update filter.zep
e5162e7
@sergeyklay @pantaovay
Replaced spaces to tabs
3e834ea
@altapo @pantaovay
Add 'strict' option in ExclusionIn validator
a43f4cb
@altapo @pantaovay
Update CHANGELOG.md
45949db
@sergeyklay @pantaovay
Added Text::humanize, Text::underscore
a779fda
@sergeyklay @pantaovay
Update routeinterface.zep
0ff2b00
@sergeyklay @pantaovay
Fixed issue phalcon#11109
0850151
@sergeyklay @pantaovay
Fixed Serghei email
04a942a
@sergeyklay @pantaovay
Fixed issue phalcon#11112 [ci skip]
9127811
@sergeyklay @pantaovay
Fixed issue phalcon#11115 [ci skip]
95d67fb
@sergeyklay @pantaovay
Amended doc for Phalcon\Security\Random [ci skip]
b40a700
@pantaovay
Merge branch '2.0.x' of https://github.com/pantaovay/cphalcon into 2.0.x
b4aece6
@pantaovay pantaovay mentioned this pull request Nov 12, 2015
Closed
@pantaovay
Copy link
Author

@sergeyklay

@sergeyklay
Copy link
Contributor

Could you please submit just the commits that belong to the PR?

@pantaovay pantaovay closed this Nov 16, 2015
@pantaovay pantaovay deleted the 2.0.x branch November 16, 2015 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.