Fixed checking case insensitive image extensions #10141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaced strcmp with strcasecmp for checking image extenstions
|
or just use one time |
|
@sergeyklay +1 |
|
That is how I use it while I code, and I did not want to change the programming style of the file
|
|
@sergeyklay +1 |
|
@agim-alb Could you please change it to one strtolower? |
…ng images (was imagejpeg)
|
Changed it using strtolower. Also fixed a bug using imagepng instead of imagejpeg to create png images |
👍 |
andresgutierrez
added a commit
that referenced
this pull request
Apr 25, 2015
Fixed checking case insensitive image extensions
|
I'v reverted this merge, could you please submit it to the 2.0.x branch? |
agim-a
added a commit
to agim-a/cphalcon
that referenced
this pull request
Apr 25, 2015
Also fixed a bug using imagepng instead of imagejpeg to create png images From pull request phalcon#10141
|
Oh.. it was a PR to the master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced strcmp with strcasecmp for checking image extenstions