Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pre-emptively cull unsatisfiable interpreter constraints. #2542

Merged
merged 4 commits into from
Sep 19, 2024

Conversation

jsirois
Copy link
Member

@jsirois jsirois commented Sep 19, 2024

When --interpreter-constraints are specified that are unsatisfiable,
Pex now either errors if all given interpreter constraints are
unsatisfiable or else warns and continues with only the remaining valid
interpreter constraints after culling the unsatisfiable ones.

Fixes #432

When `--interpreter-constraint`s are specified that are unsatisfiable,
Pex now either errors if all given interpreter constraints are
unsatisfiable or else warns and continues with only the remaining valid
interpreter constraints after culling the unsatisfiable ones.

Fixes pex-tool#432
@jsirois
Copy link
Member Author

jsirois commented Sep 19, 2024

Pants reviewers, you're on here due to pantsbuild/pants#21429
Please take a look both here and at the Pants issue. FWICT, the OP in the Pants issue indicates a Pants bug synthesizing ICs and all the user input ICs are individually satisfiable. My fix here only helps the case when the user supplies unsatisfiable constraints. When Pants does on their behalf as a middle-man, they'll of course still be super confused; so if Pants is synthesizing ICs buggily, that probably ought to be addressed.

Copy link
Collaborator

@benjyw benjyw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll take a look at the pants side of things, thanks.

CHANGES.md Outdated Show resolved Hide resolved
Co-authored-by: Benjy Weinberger <[email protected]>
@jsirois jsirois merged commit da262e7 into pex-tool:main Sep 19, 2024
23 checks passed
@jsirois jsirois deleted the issues/432 branch September 19, 2024 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add interpreter constraint checking for mutually exclusive constraints
2 participants