Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add interpreter constraint checking for mutually exclusive constraints #432

Closed
CMLivingston opened this issue Dec 1, 2017 · 0 comments · Fixed by #2542
Closed

Add interpreter constraint checking for mutually exclusive constraints #432

CMLivingston opened this issue Dec 1, 2017 · 0 comments · Fixed by #2542
Assignees
@jsirois
Labels
bug enhancement

Comments

@CMLivingston
Copy link
Contributor

Currently, the interpreter constraint validation in the validate_constraints method of interpreter_constraints.py only checks to see if constraints are properly formed.

Add logic to validate_constraints to ensure that they are not mutually exclusive so we can fail early and not waste the user's time.
@jsirois jsirois self-assigned this Sep 19, 2024
@jsirois jsirois mentioned this issue Sep 19, 2024
Open
jsirois added a commit to jsirois/pex that referenced this issue Sep 19, 2024
@jsirois
Pre-emptively cull unsatisfiable interpreter constraints.
ca94e77 
When `--interpreter-constraint`s are specified that are unsatisfiable,
Pex now either errors if all given interpreter constraints are
unsatisfiable or else warns and continues with only the remaining valid
interpreter constraints after culling the unsatisfiable ones.

Fixes pex-tool#432
@jsirois jsirois mentioned this issue Sep 19, 2024
Merged
jsirois added a commit that referenced this issue Sep 19, 2024
@jsirois @benjyw
Pre-emptively cull unsatisfiable interpreter constraints. (#2542)
da262e7 
When `--interpreter-constraint`s are specified that are unsatisfiable,
Pex now either errors if all given interpreter constraints are
unsatisfiable or else warns and continues with only the remaining valid
interpreter constraints after culling the unsatisfiable ones.

Fixes #432

---------

Co-authored-by: Benjy Weinberger <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jsirois jsirois

Labels
bug enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Pre-emptively cull unsatisfiable interpreter constraints. jsirois/pex
2 participants
@jsirois @CMLivingston