PEX zips now contain directory entries. #1022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously they did not which led to PEP-420 namespace packages not working in `--zip-safe` context. Fixes pex-tool#1021
Eric-Arellano
approved these changes
Aug 29, 2020
Comment on lines
+1134
to
+1136
| with temporary_dir() as output_dir: | ||
| with temporary_dir() as input_dir: | ||
| with safe_open(os.path.join(input_dir, "a/b/c.py"), "w") as fh: |
There was a problem hiding this comment.
Nit, you can combine these to reduce nesting:
with temporary_dir() as output_dir, temporary_dir() as input_dir():This is fine to keep - only want to make sure you're aware.
There was a problem hiding this comment.
Ack. I'll stick with the copypasta from the test above for now.
Comment on lines
+1672
to
+1673
| if os.path.isdir(member1_path): | ||
| continue |
There was a problem hiding this comment.
What's the reason for skipping? Are the directory entries not byte-for-byte identical?
There was a problem hiding this comment.
It's because filecmp.cmp considers anything not a regular file (symlink, directory, etc.) unequal.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously they did not which led to PEP-420 namespace packages not
working in
--zip-safecontext.Fixes #1021