Zipped PEXes don't contain directory entries. #1021
Assignees
Labels
Comments
jsirois
added a commit
to jsirois/pex
that referenced
this issue
Aug 29, 2020
Previously they did not which led to PEP-420 namespace packages not working in `--zip-safe` context. Fixes pex-tool#1021
This was referenced Aug 29, 2020
Closed
jsirois
added a commit
to jsirois/pex
that referenced
this issue
Aug 29, 2020
Previously they did not which led to PEP-420 namespace packages not working in `--zip-safe` context. Fixes pex-tool#1021
jsirois
added a commit
to jsirois/pex
that referenced
this issue
Aug 29, 2020
Previously they did not which led to PEP-420 namespace packages not working in `--zip-safe` context. Fixes pex-tool#1021
jsirois
added a commit
that referenced
this issue
Aug 29, 2020
Previously they did not which led to PEP-420 namespace packages not working in `--zip-safe` context. Fixes #1021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
PEP-420 implicit namespace packages require directories with no
__init__.pychildren to implicitly declare a namespace package. As such, the zipfile created by the Pex CLI / PEXBuilder is invalid since it only contains file entries and not directory entries. This, for example, has caused Pants (see: pantsbuild/pants#10608) to need to always mark all PEXes--not-zip-safeeven when they otherwise are to force the PEX code portion to be exploded to disk, which implicitly creates parent directories on the filesystem if needed, satisfying PEP-420.The text was updated successfully, but these errors were encountered: