Fix for getDirectoryContents on Windows (Fixes issue #101) #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
perry-mitchell
approved these changes
Sep 11, 2018
|
This should be solved another way. PR completely broke the ability to use webdav in the browser. It would be great to have checks for this sort of stuff. path-browserify doesn't implement posix yet browserify/path-browserify#11 |
|
You’re right.. a compiled web test would be ideal for catching this. I wonder if an external posix lib like the following would work for the time being?
https://www.npmjs.com/package/path-posix
|
|
Issue will continue in #104 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is a fix for the reported problem with the result of getDirectoryContents on Windows (issue #101)
Fixes #101