Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.5.4] path.posix breaks in browserify #104

Closed
perry-mitchell opened this issue Sep 13, 2018 · 3 comments
Closed

[1.5.4] path.posix breaks in browserify #104

perry-mitchell opened this issue Sep 13, 2018 · 3 comments
Assignees
@perry-mitchell
Labels
Priority: Critical Status: Completed Type: Bug

Comments

@perry-mitchell
Copy link
Owner

This should be solved another way. PR completely broke the ability to use webdav in the browser. It would be great to have checks for this sort of stuff.

path-browserify doesn't implement posix yet browserify/path-browserify#11
@perry-mitchell
Copy link
Owner Author

Considering using the https://www.npmjs.com/package/path-posix library to solve this issue.

@perry-mitchell perry-mitchell mentioned this issue Sep 13, 2018
Merged
@perry-mitchell
Copy link
Owner Author

The more I read on this the better this idea seems.. Using this library will circumvent the need for the node package. It does require the util node package, but from the sounds of things this should build in webpack just fine.

@perry-mitchell perry-mitchell self-assigned this Sep 13, 2018
@perry-mitchell perry-mitchell mentioned this issue Sep 13, 2018
Merged
@perry-mitchell
Copy link
Owner Author

Released in 1.5.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@perry-mitchell perry-mitchell

Labels
Priority: Critical Status: Completed Type: Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@perry-mitchell