Auto-execute all files from a glob or a dir #39
Conversation
Codecov Report
@@ Coverage Diff @@
## master #39 +/- ##
==========================================
+ Coverage 93.72% 93.73% +<.01%
==========================================
Files 13 13
Lines 685 702 +17
Branches 124 128 +4
==========================================
+ Hits 642 658 +16
Misses 20 20
- Partials 23 24 +1
Continue to review full report at Codecov.
|
| self._load_schema_fullpath_file(path) | ||
| else: | ||
| for file_path in sorted(glob.glob(path)): | ||
| if os.path.isfile(file_path) and file_path.endswith('.sql'): |
There was a problem hiding this comment.
But what if the glob points to a dir, though ?
There was a problem hiding this comment.
I don't think it's a expected behavior to load multiple files and dird over a glob. And we don't want a recursive search.
I don't know use case to include a glob of dirs, and I don't think it was desired.
But I can do it if you think it's better ?
There was a problem hiding this comment.
I don't know. I'd find it logical if it did, but I really don't know if it's ever going to be used. For me it's more along the lines of "it it simplifies the code, let's do it".
There was a problem hiding this comment.
This is good,
I'd like to see if it's possible to split a little more the logic and the I/Os., and burry the I/Os a little less.
I see 3 I/O operations:
- glob.glob (that matches with the disks contents)
- Seeing of a path is a dict
- Reading the file and running it.
Would it be possible to do the work in 3 phases:
- Use glob to get all the paths
- Expand dirs on all the paths
- run script on all resulting paths
That would be 3 sequential loops instead of nesting loops and ifs (flat is better than nested). If it's not very clear, get in touch. Anyway, I'm not opposed to merging as-is as well.
Use only the glob to find files on `NORTH_BEFORE_SCHEMA_FILES` and `NORTH_AFTER_SCHEMA_FILES`
Closes: peopledoc/septentrion#24