Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-execute all files from a folder #24

Open
ewjoachim opened this issue Aug 20, 2019 · 7 comments · Fixed by peopledoc/django-north#39
Open

Auto-execute all files from a folder #24

ewjoachim opened this issue Aug 20, 2019 · 7 comments · Fixed by peopledoc/django-north#39
Labels
enhancement New feature or request

Comments

@ewjoachim
Copy link
Contributor

ewjoachim commented Aug 20, 2019

When referencing a folder in NORTH_BEFORE_SCHEMA_FILES and NORTH_AFTER_SCHEMA_FILES, all files in it should be executed in sorted order

@ewjoachim ewjoachim added the enhancement New feature or request label Aug 20, 2019
@ewjoachim
Copy link
Contributor Author

ewjoachim commented Aug 26, 2019

Maybe a list of glob-style paths would fit even better. Maybe it could also have an exclusion pattern (!, à-la gitignore), it would also ease things.

Ping @samuelhamard.
(note: this is a public repo :) )

@samuelhamard
Copy link
Contributor

Referencing a folder is I think a good feature, but a list of glob-style path fit even better with my need.

@ewjoachim
Copy link
Contributor Author

Let's work on that on a friday sometime :)

@samuelhamard samuelhamard pinned this issue Aug 27, 2019
@samuelhamard samuelhamard unpinned this issue Aug 27, 2019
@samuelhamard
Copy link
Contributor

If the reference is a directory which contain sub directories, do we want to walk in all sql files of the tree, or just the sql files on the root directory ?

@ewjoachim
Copy link
Contributor Author

Hmm, I'd say just the directory, not recursively. What's your take ?

@samuelhamard
Copy link
Contributor

The directory is good.

@ewjoachim
Copy link
Contributor Author

ewjoachim commented Oct 25, 2019

It's nice that it's been solved in Django North, but we still have to do the same in septentrion :)
As long as we don't refactor the 2 libs to share the same core, they're 2 distinct libs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants