Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prepare v0.19.0, bump tower dep to v0.5 #59

Merged
merged 3 commits into from
Feb 4, 2025
Merged

prepare v0.19.0, bump tower dep to v0.5 #59

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0aa2053
bump [email protected]
SuperFluffy Feb 4, 2025
4fb7de7
activate tokio, tower features for examples, tests
SuperFluffy Feb 4, 2025
9fb3903
set version to 0.19.0
SuperFluffy Feb 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[package]
name = "tower-abci"
version = "0.18.0"
version = "0.19.0"
authors = [
"Penumbra Labs <[email protected]>",
"Henry de Valence <[email protected]"
Expand All @@ -17,17 +17,19 @@ documentation = "https://docs.rs/tower-abci"
tendermint-proto = "0.40"
tendermint = "0.40"
bytes = "1"
tokio = { version = "1", features = ["full"]}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Paged out the details of why, but iirc this is needed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can move this change to a separate PR if you want - but the features are not fully needed (for both tokio and tower). More of the features are needed for the examples to work, but not the full set.

Reason to not have this is to not pull in the entire kitchen sink when importing tower-abci.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need, sounds good. Thx

tokio = { version = "1", features = ["io-util", "macros", "net", "rt"] }
tokio-util = { version = "0.6", features = ["codec"] }
tokio-stream = "0.1"
tower = { version = "0.4", features = ["full"]}
tower = { version = "0.5", features = ["util"] }
pin-project = "1"
futures = "0.3"
tracing = "0.1"
prost = "0.13"

[dev-dependencies]
structopt = "0.3"
tokio = { version = "1", features = ["rt-multi-thread"] }
tower = {version = "0.5", features = ["buffer", "limit", "load-shed"] }
tracing-subscriber = "0.3.17"

[features]
Expand Down
Loading