prepare v0.19.0, bump tower dep to v0.5 #59
Conversation
| @@ -17,10 +17,10 @@ documentation = "https://docs.rs/tower-abci" | |||
| tendermint-proto = "0.40" | |||
| tendermint = "0.40" | |||
| bytes = "1" | |||
| tokio = { version = "1", features = ["full"]} | |||
There was a problem hiding this comment.
Paged out the details of why, but iirc this is needed.
There was a problem hiding this comment.
I can move this change to a separate PR if you want - but the features are not fully needed (for both tokio and tower). More of the features are needed for the examples to work, but not the full set.
Reason to not have this is to not pull in the entire kitchen sink when importing tower-abci.
|
ACK, will merge on green CI, do you need a new release as well? |
|
@erwanor CI should pass now. The change in features is technically not best practice in PRs, but I figured it's minimal and not observable outside of tower-abci. Let me know if you want me to move this to a separate PR. And yes, a release would be nice. |
|
Can you bump the crate version in the PR pls, i will squash and release from the UI. afk |
SuperFluffy
changed the title
Updated the version and the PR title |
Bumps tokio-util to 0.7. Similar to PR #59, this sets the version to 0.19.1. I went through all imports of tokio_utils and it looks like none of it is part of the crate's public API, making this a minor release. The only `pub` marked items are the `v{034,037,038}::codex::{Decode}` types, which `impl tokio_util::codec::Decoder` and `impl tokio_util::codec::Decoder`. But the crate does not actually export any of these items (and the `*::codex` modules stay private).
Bumps tower to v0.5 to match the rest of the ecosystem (tonic, axum).