GEOS 3.8 compile fix#1497
Closed
remoe wants to merge 1 commit intopelicanmapping:masterfrom
remoe:patch-13
Closed
Conversation
ankurvdev
reviewed
Sep 5, 2020
| } | ||
| #if GEOS_VERSION_AT_LEAST(3,8) | ||
| geom::CoordinateSequence::Ptr seq = factory->create(coords); | ||
| return seq.get(); |
There was a problem hiding this comment.
This seems wrong. Ptr is a unique_ptr so the memory will be freed up as soon as the function is returned.
This function would be returning freed up memory.
seq.release is probably what would work here but there migh be a memory leak
Member
|
I just pushed a change to build against the geos c API which should be fine
against 3.8. Make sure you link against the geos_c.lib and not the
geos.lib when you rebuild.
…On Sat, Sep 5, 2020, 1:38 PM ankurverma85 ***@***.***> wrote:
osgearth seems broken after the geos 3.8.1 update.
I'm curious as to how did the geos update sneak in (which breaks osgearth)
without triggering a pipeline build failure in osgearth.
Shouldnt this have been caught by the pipeline build in the Pull-Request
for the geos 3.8.1 update ?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#1497 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACPXYVNJ4WWBO45TX35XVLSEJZQXANCNFSM4MLXTJUA>
.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix for #1455 and #1378
for osgEarth 3.0