[osgearth] Adapt to the geos latest version#13332
[osgearth] Adapt to the geos latest version#13332JackBoosY wants to merge 1 commit intomicrosoft:masterfrom
Conversation
JackBoosY
added
category:port-bug
| coords->push_back( coords->front() ); | ||
| } | ||
| +#if GEOS_VERSION_AT_LEAST(3,8) | ||
| + geom::CoordinateSequence::Ptr seq = factory->create(coords); |
There was a problem hiding this comment.
This seems wrong.
geom::CoordinateSequence::Ptr is a unique_ptr which will be released as soon as the context goes out of scope.
You will be returning a freed memory by returning seq.get()
seq.release would probably work but there might be a memory leak
osgearth seems broken after the geos 3.8.1 update. |
|
Seems like the right fix has been merged into osgearth pelicanmapping/osgearth@ef631e0 Can we perhaps abandon the Pull-Request and move over the port to the above commit ? |
|
created a pull request with the right commit |
3 participants
Due to the update of geos to 3.8.1, osgearth cannot adapt to the changes of the new version(pelicanmapping/osgearth#1455).
Use the unofficial changes pelicanmapping/osgearth#1497 to fix the issue.
Will merge this issue after pelicanmapping/osgearth#1497 merged.
Fixes #13292.