Refactor S3 model logic into abstract base classes #297
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Spacerat
force-pushed
the
feature/file-model-refactor
branch
from
0bd8d7d to
b4ccef5
Compare
added 2 commits
June 7, 2016 11:37
# Conflicts: # ide/api/project.py # ide/api/source.py # ide/models/files.py # ide/tasks/archive.py
ide/models/scriptfile.py
Outdated
| from ide.models.s3file import S3File | ||
|
|
||
|
|
||
| class ScriptFile(S3File): |
Contributor
Author
There was a problem hiding this comment.
The motivation is that it is the superclass of both SourceFile and TestFile (monkeyscripts) in the test bench branch. I don't mind changing the name if you can think of something more suitable
Contributor
Author
There was a problem hiding this comment.
In fact, the comment is wrong. It should say "ScriptFiles add support to S3Files for last-modified timestamps and code folding". Which makes me think that TextFile is a reasonable alternative name
Contributor
Author
|
OK, I renamed ScriptFile to TextFile |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an enabling PR for the test-bench branch, but is also an improvement in its own right. It makes the following changes:
SourceFiles.save_file(text)andResourceVariants.save_file(stream). Now,S3File.save_text(text)replaces the SourceFile's version, and all usage is renamed accordingly.files.pyforAWS_ENABLED==Falseis now contained in a small set of functions in S3File, which will make them easy to remove if we ever want to.