Validation improvements #321
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Spacerat
force-pushed
the
bugfix/validation
branch
from
e2dbd69 to
aece9f7
Compare
Merged
Katharine
force-pushed
the
bugfix/validation
branch
from
aece9f7 to
b8c09a6
Compare
| class ResourceIdentifier(IdeModel): | ||
| resource_file = models.ForeignKey(ResourceFile, related_name='identifiers') | ||
| resource_id = models.CharField(max_length=100) | ||
| resource_id = models.CharField(max_length=100, validators=regexes.validator('c_identifier', _("Invalid resource ID."))) |
Member
There was a problem hiding this comment.
This isn't quite right; resource IDs are prefixed and so don't have the usual start-of-identifier rules.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves validation in a few ways:
pre_save_full_clean_handlerin meta.py triggers model validation any time a model is saved (includingModel.object.create)ResourceIdentifier.resource_id,BuildResult.uuidandProject.uuid.ide/utils/regexes.pyand are made available to the templates with{% regexes.regex_name %}and the clientside JS with the global objectREGEXES.regex_name.(depends on #297)