Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: bump to use node20 runtime #641

Merged
merged 8 commits into from
Feb 6, 2024
Merged

feat: bump to use node20 runtime #641

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
7a931cb
feat: bump nvmrc and engine constraint to node 20
chenrui333 Dec 21, 2023
0baec7d
feat: update to use nodejs20 runtime
chenrui333 Dec 21, 2023
d5ef30d
update @types/node to v20
chenrui333 Dec 21, 2023
9227739
bump version to 3.0.0 per nodejs20 upgrade
chenrui333 Dec 21, 2023
b616c0b
chore: update ncc to latest
chenrui333 Dec 22, 2023
194ee82
chore: no fail-fast for CI builds
chenrui333 Dec 22, 2023
6ed77e1
update branch trigger to test the worklow runs in fork
chenrui333 Dec 22, 2023
2135c0a
Revert "update branch trigger to test the worklow runs in fork"
chenrui333 Dec 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .github/workflows/test-action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ jobs:
strategy:
matrix:
os:
- 'ubuntu-22.04'
chenrui333 marked this conversation as resolved.
Show resolved Hide resolved
- 'ubuntu-20.04'
- 'ubuntu-latest'
- 'macos-latest'
Expand Down
11 changes: 4 additions & 7 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ jobs:
test:
runs-on: ${{ matrix.os }}
strategy:
fail-fast: false
matrix:
os:
- 'ubuntu-22.04'
Expand All @@ -24,14 +25,10 @@ jobs:
steps:
- uses: actions/checkout@v4

- name: Read .nvmrc
run: echo "::set-output name=NVMRC::$(cat .nvmrc)"
id: nvm

- name: Setup Node
uses: actions/[email protected]
- uses: actions/setup-node@v4
with:
node-version: '${{ steps.nvm.outputs.NVMRC }}'
node-version-file: '.nvmrc'
chenrui333 marked this conversation as resolved.
Show resolved Hide resolved
cache: 'npm'

- run: npm ci

Expand Down
2 changes: 1 addition & 1 deletion .nvmrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
12.22.4
20.10.0
5 changes: 2 additions & 3 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -261,10 +261,9 @@ jobs:
hugo-version: '0.119.0'
extended: true

- name: Setup Node
uses: actions/setup-node@v3
- uses: actions/setup-node@v4
with:
node-version: '18'
node-version: '20'
cache: 'npm'
# The action defaults to search for the dependency file (package-lock.json,
# npm-shrinkwrap.json or yarn.lock) in the repository root, and uses its
Expand Down
2 changes: 1 addition & 1 deletion action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ inputs:
required: false
default: 'false'
runs:
using: 'node16'
using: 'node20'
main: 'lib/index.js'
branding:
icon: 'package'
Expand Down
58 changes: 38 additions & 20 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 5 additions & 5 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
{
"name": "actions-hugo",
"version": "2.6.0",
"version": "3.0.0",
"description": "GitHub Actions for Hugo",
"main": "lib/index.js",
"engines": {
"node": ">=16.18.0",
"npm": ">=8.19.0"
"node": ">=20.10.0",
"npm": ">=10.2.3"
},
"scripts": {
"all": "npm run format:check && npm run lint && npm test",
Expand Down Expand Up @@ -55,11 +55,11 @@
},
"devDependencies": {
"@types/jest": "^26.0.20",
"@types/node": "~12",
"@types/node": "~20",
"@types/node-fetch": "^2.5.8",
"@typescript-eslint/eslint-plugin": "^4.16.1",
"@typescript-eslint/parser": "^4.16.1",
"@vercel/ncc": "^0.27.0",
"@vercel/ncc": "^0.38.1",
"eslint": "^7.21.0",
"eslint-plugin-jest": "^24.1.5",
"husky": "^5.1.3",
Expand Down