Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: bump to use node20 runtime #641

Merged
merged 8 commits into from
Feb 6, 2024
Merged

Conversation

chenrui333
Copy link
Contributor

This is consistent with all the recent github action updates. (mostly in actions repos, like actions/checkout, actions/setup-node, etc.)


Node12 was deleted from runner. Node20 was added to Actions Runner on v2.308.0.
Node16 has en end of life on 11 Sep 2023.

This PR updates the default runtime to node20, rather then node16

relates to actions/runner#2732

@chenrui333
Copy link
Contributor Author

cc @peaceiris (it would also need a major release 3.0.0 after the PR merge)

peaceiris
peaceiris previously approved these changes Dec 22, 2023
Copy link
Owner

@peaceiris peaceiris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much!

@peaceiris
Copy link
Owner

It will be released as the first version of 2024 together with other bug fixes! ʕ◔ϖ◔ʔ

Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 9445 lines exceeds the maximum allowed for the inline comments feature.

@chenrui333
Copy link
Contributor Author

looks like CI is not happy with the dist artifact checkin, I will move it into separate PR.

@chenrui333
Copy link
Contributor Author

@peaceiris works fine now, https://github.com/chenrui333/actions-hugo/actions/runs/7296900196

@cagataygurturk
Copy link

Any ETA for its release?

@peaceiris
Copy link
Owner

Thank you so much! ʕ◔ϖ◔ʔ

@peaceiris peaceiris merged commit c57490a into peaceiris:main Feb 6, 2024
3 checks passed
@melhuang
Copy link

melhuang commented Feb 9, 2024

do we need to wait for a major version release as well?

sauricat pushed a commit to sauricat/actions-hugo that referenced this pull request Mar 4, 2024
pryrt referenced this pull request in notepad-plus-plus/npp-usermanual Mar 28, 2024
@chenrui333
Copy link
Contributor Author

@peaceiris we need a major version release per this merge.

@peaceiris
Copy link
Owner

peaceiris commented Apr 8, 2024

The tag v3.0.0 was released last week. The v3 tag is also available. ʕ◔ϖ◔ʔ

https://github.com/peaceiris/actions-hugo/releases/tag/v3.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants