Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readme benefits and proxy suggestion #29

Merged
merged 1 commit into from
Nov 4, 2022

Conversation

nickfarrow
Copy link
Collaborator

Add clarity to benefits and usage instructions (suggest that proxy method for all OSs).

@nickfarrow nickfarrow changed the title Update readme Readme benefits and proxy suggestion Oct 24, 2022
Copy link
Contributor

@DanGould DanGould left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing loin to nolooking are the most important. I think the links at the top are helpful too

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@DanGould
Copy link
Contributor

Nicely done!

@nickfarrow
Copy link
Collaborator Author

nickfarrow commented Nov 3, 2022

Thoughts on defaulting to

const STATIC_DIR: &str = "static";

Even without test_paths feature flag?

I think it is easier for people to run nolooking within the directory, with the option of setting a config arg to place it in more exotic locations if need be

Edit: made issue: #46

README.md Outdated Show resolved Hide resolved
Update suggested wallets. Move `Usage` section to the start.
Simplify usage instructions and proxy suggestion. Rename to
nolooking.
@nickfarrow
Copy link
Collaborator Author

fixed extra space and force pushed

@DanGould DanGould merged commit fadf5d7 into payjoin:master Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants