Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make STATIC_DIR an argument and get rid of test_paths feature #46

Open
nickfarrow opened this issue Nov 3, 2022 · 1 comment
Open

Comments

@nickfarrow
Copy link
Collaborator

nickfarrow commented Nov 3, 2022

I think by default we should use

STATIC_DIR = "static";

And give people the option of setting it using a config argument if they want to host nolooking from a more exotic directory.

Then could we get rid of the test_paths feature, instead passing it as an argument with the tests?

@Kixunil
Copy link
Contributor

Kixunil commented Nov 17, 2022

I think there should be some build-time option to use a specific default directory so people using packaged version don't need to override it. But maybe it's best to just set default in config_spec.toml and patch it during packaging. Maybe this is something configure_me should support better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants