Replace ryu with zmij for float formatting #772
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change moves from ryu to zmij for floating-point to string conversion in serde arbitrary precision deserialization. This follows the same direction as serde_json: serde-rs/json#1304 Related to: paupino#761
Contributor
Author
|
I can open the same PR against main this time sorry I missed it last time. |
Collaborator
|
There's a 1.0 release as of 3 weeks ago. Do we have a specific reason to depend on the unstable version instead of the 1.0? |
Contributor
Author
I picked the same version I saw used in serde-rs/json I'll look into using 1.0 |
Collaborator
|
serde-rs/json@1aefe15 |
Contributor
Author
Great! Thanks for flagging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
ryuwithzmijfor floating-point to string conversion in serde arbitrary precision deserializationRelated