Fixed Issue #760 serde_json roundtrip on specific values (0.0, 1.0, 2.0,...) #761
+39
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tony-Samuels
reviewed
Nov 5, 2025
Collaborator
|
I didn't realise this was easy to fix. Nice job. |
Collaborator
|
Please can you raise a similar MR against |
Contributor
Author
Sorry I didn't catch that, I'm working on an update and I'll make sure that I raise it against |
hugobast
added a commit
to hugobast/rust-decimal
that referenced
this pull request
Jan 14, 2026
This change moves from ryu to zmij for floating-point to string conversion in serde arbitrary precision deserialization. This follows the same direction as serde_json: serde-rs/json#1304 Related to: paupino#761
hugobast
added a commit
to hugobast/rust-decimal
that referenced
this pull request
Jan 14, 2026
Uses zmij for floating-point to string conversion to avoid precision loss during deserialization. This follows the same direction as serde_json: serde-rs/json#1304 Related to: paupino#761
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Providing a fix for #760 in case there's appetite for it.
In my opinion this is a bug worth fixing because it aligns with this crate's purpose, it was surprising to discover that "1.0" would get turned into "1".
It's an unfortunate side effect of serde_json's
arbitrary_precisionlogic which for some values (0.0, 1.0, ...) will decide to usevisit_f64instead of avisit_map.Key Changes
ryudependency to Cargo.toml (only forserde-with-arbitrary-precision)Rationale
The decision to include
ryuas a dependency with the featureserde-with-arbitrary-precisionaligns withserde_json's own usage of said dependency witharbitrary_precisionenabled.