Slight improvements to monaco upgrade#4
Merged
paulinashakirova merged 2 commits intoApr 29, 2026
Merged
Conversation
eokoneyo
commented
Apr 27, 2026
|
|
||
| return await inlineSuggest(fullText, textBeforeCursor, range, callbacks); | ||
| }, | ||
| freeInlineCompletions: () => {}, |
Author
There was a problem hiding this comment.
freeInlineCompletions is now deprecated, so don't need to pass it along
eokoneyo
commented
Apr 27, 2026
| position.column | ||
| ); | ||
|
|
||
| return inlineSuggest(fullText, textBeforeCursor, range, callbacks); |
Author
There was a problem hiding this comment.
We should probably ask the esql team to modify this as an improvement to accept an abortController signal, so that if the inline completion is cancelled by monaco we are also able to terminate the already running promise if it's not resolved yet
paulinashakirova
merged commit b0e84fa
into
paulinashakirova:update-monaco-latest
7 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tiny fixes for monaco upgrade PR