[WIP]Update monaco latest#242860
Draft
paulinashakirova wants to merge 17 commits into
Draft
Conversation
paulinashakirova
added
release_note:skip
Contributor
|
🤖 Jobs for this PR can be triggered through checkboxes. 🚧
ℹ️ To trigger the CI, please tick the checkbox below 👇
|
eokoneyo
reviewed
Nov 14, 2025
Comment on lines
+669
to
+671
| bracketPairColorization: { | ||
| enabled: false, | ||
| }, |
Contributor
There was a problem hiding this comment.
I have't tried out your PR however I noticed the former linked issue is still open, if it works somehow we'll need to apply this change in other places in the codebase that do the same for their custom implementation, see
|
|
||
| // Mock navigator.clipboard for Monaco Editor 0.45.0+ | ||
| // Monaco's Safari workaround cancels internal DeferredPromises, causing unhandled rejections in tests | ||
| Object.defineProperty(navigator, 'clipboard', { |
Contributor
Author
There was a problem hiding this comment.
This workaround is defined in node_modules/monaco-editor/esm/vs/platform/clipboard/browser/clipboardService.js (lines 41-43 and 68 - 92)
if (isSafari || isWebkitWebView) {
this.installWebKitWriteTextWorkaround();
}
| }, | ||
| ], | ||
| }, | ||
| }); |
Contributor
Author
There was a problem hiding this comment.
Removing this optimization because as @eokoneyo explained
in the version we upgrading away from, the file referenced in the exclude pattern because it was already transformed to ESM, so when we include it to be optimized (i.e treeshaking and the likes) it would break
hence why we excluded it from any kind of optimization and just use as is, and in the new version it doesn't cause any issues.
| } | ||
|
|
||
| // Monaco's Safari workaround (added in 0.45.0) uses ClipboardItem, which doesn't exist in JSDOM | ||
| if (!Object.hasOwn(global, 'ClipboardItem')) { |
Contributor
Author
There was a problem hiding this comment.
Before 0.45.0: Tests didn't need ClipboardItem because Monaco either used navigator.clipboard.writeText() or fell back to execCommand.
In 0.45.0: Monaco added the Safari-specific workaround that uses navigator.clipboard.write([new ClipboardItem({...})]), which requires both the ClipboardItem class.
Contributor
|
@elasticmachine merge upstream |
Contributor
|
merge conflict between base and head |
eokoneyo
force-pushed
the
update-monaco-latest
branch
from
ab501d2 to
c126d8b
Compare
eokoneyo
force-pushed
the
update-monaco-latest
branch
3 times, most recently
from
bc8ecd2 to
3025a2d
Compare
eokoneyo
force-pushed
the
update-monaco-latest
branch
2 times, most recently
from
1cc0b47 to
bbc29a2
Compare
paulinashakirova
force-pushed
the
update-monaco-latest
branch
from
e5e55fb to
0100c96
Compare
![macroscopeapp[bot]](https://avatars.githubusercontent.com/in/900172?s=60&v=4){kind=small}
paulinashakirova
force-pushed
the
update-monaco-latest
branch
from
f29e338 to
65ff09b
Compare
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
Contributor
Flaky Test Runner Stats🟠 Some tests failed. - kibana-flaky-test-suite-runner#11658[❌] src/platform/test/functional/apps/console/config.ts: 0/15 tests passed. |
Contributor
Flaky Test Runner Stats🟠 Some tests failed. - kibana-flaky-test-suite-runner#11700[✅] x-pack/platform/test/functional/apps/index_management/config.ts: 15/15 tests passed. |
…torWrapper, improving error handling for test subjects.
This reverts commit 32a6ace.
The **/prettier: 3.8.1 resolution forced eslint-plugin-prettier@4.2.1's nested prettier to 3.x, but the plugin calls prettier.resolveConfig.sync which was removed in prettier 3 — breaking every lint batch in CI with "TypeError: prettier.resolveConfig.sync is not a function". Removing the resolution lets eslint-plugin-prettier resolve its expected prettier@^2.x peer (2.8.8), matching how main is configured. yarn.lock regenerated and verified stable across two bootstrap passes. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
…code-editor - Updated import paths in `use_editor_config.ts` to consolidate Monaco-related imports from `@kbn/code-editor`. - Modified `worker_factory.ts` to import language IDs from their respective constants files. - Adjusted `supported.ts` to streamline language exports from `@kbn/monaco`. - Changed import statements in `use_workflow_events_on_decorations.ts` and its test file to utilize `@kbn/code-editor` instead of `@kbn/monaco` for consistency.
- Updated the addColumn method to include retry logic when clicking the 'indexEditorAddColumnButton' and setting the column type, enhancing reliability in the index editor functionality.
- Added a check to ensure the 'indexEditorColumnTypeSelect' exists before setting the column type, improving the robustness of the addColumn method in the index editor functionality.
- Added a clear step for the 'indexEditorColumnTypeSelect' combo box to prevent desynchronization issues with React state during re-renders. - Included a verification step to ensure the 'indexEditorColumnNameInput' appears after setting the column type, enhancing the reliability of the addColumn functionality.
…error handling in worker factory - Updated the access method for the Monaco environment in `WorkflowEditorPage` to remove TypeScript's `any` type casting, enhancing type safety. - Improved error handling in `getWorkerUrl` by throwing an error when the Monaco bundle directory cannot be resolved, instead of returning an empty string.
…ally, or add an exception to src/dev/yarn_deduplicate/index.ts and then commit the changes and push to your branch
eokoneyo
force-pushed
the
update-monaco-latest
branch
from
5213392 to
c0eb8f0
Compare
Contributor
|
/ci |
Contributor
|
@elasticmachine merge upstream |
Contributor
|
/ci |
Contributor
Author
|
/ci |
Contributor
💔 Build Failed
Failed CI Steps
Test Failures
Metrics [docs]Module Count
Async chunks
Page load bundle
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is a collaborative PR with some of the code from @eokoneyo's draft PR.
The main goal is to upgrade monaco editor that Renovate requested.
Here is the PR from Renovate with version bump, but because we have breaking changes and need more updates this PR is necessary.