feat: round-trip cipherSuites in share links and VMess QR code - #3
Merged
Conversation
The fork already round-trips its custom TLS fields (ech, vcn, pcs, pqv) through share-link query parameters and the VMess QR-code JSON, but cipherSuites was missing, so sharing a profile silently dropped it. Add a "cs" query parameter to FmtBase import/export and a "cs" field to VmessQRCode, mapped in VmessFmt parse/toUri, following the existing pattern (emitted only when non-blank). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This was referenced Jul 10, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #1 and #2. This commit was pushed to the
fix/cipher-suites-followupbranch after #2 had already been merged, so it never landed in master — this PR picks it up.What changed
The fork already round-trips its custom TLS fields (
ech,vcn,pcs,pqv) through share-link query parameters and the VMess QR-code JSON, butcipherSuiteswas missing, so sharing or exporting a profile silently dropped the setting.FmtBase.getItemFormQuery/getQueryDic: import and export acsquery parameter (emitted only when non-blank, matching the existing pattern).VmessQRCode: newcsfield in the QR-code JSON DTO.VmessFmt.parse/toUri: mapcstoProfileItem.cipherSuitesin both directions.Note for reviewers
The matching
cskey is not yet supported by the v2rayN fork'sBaseFmt.cs, so links carryingcs=interop with v2rayN only once the same key is added there.🤖 Generated with Claude Code