fix: add missing cipherSuites locale strings and equals comparison (follow-up to #1) - #2
Merged
Merged
Conversation
Add the server_lab_cipher_suites label to all 8 locale strings.xml files (ar, bn, bqi-rIR, fa, ru, vi, zh-rCN, zh-rTW), which #1 only added to the default values/strings.xml. Also compare cipherSuites in ProfileItem.equals so profiles differing only in cipher suites are not treated as duplicates and deleted by "remove duplicate servers". Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #1, which added the
cipherSuitesTLS option and theunsafefingerprint but left some gaps.What changed
server_lab_cipher_suiteswas only added to the defaultvalues/strings.xml. This adds it to all 8 locale files (ar, bn, bqi-rIR, fa, ru, vi, zh-rCN, zh-rTW), placed afterserver_lab_stream_alpnand styled to match each file's existing conventions.ProfileItem.equals: now comparescipherSuites. This method drives "remove duplicate servers" inMainViewModel, so two profiles differing only in cipher suites were treated as duplicates and one was silently deleted.alpnandfingerPrintare already compared there.ech,vcn,pcs,pqv) through share-link query parameters and the VMess QR-code JSON, butcipherSuiteswas missing, so sharing a profile silently dropped it. Adds acsquery parameter toFmtBaseimport/export and acsfield toVmessQRCode, mapped inVmessFmt, emitted only when non-blank.Notes for reviewers
unsafefingerprint entry needed no locale work:arrays.xmlexists only invalues/and istranslatable="false"; the spinner anduTlsItemsboth readR.array.streamsecurity_utlsdirectly.equalsalso omitsinsecure,echConfigList,verifyPeerCertByName,spiderX, andmldsa65Verify; and per Xray docsunsafeis a TLSObject-only fingerprint, but the spinner is shared with REALITY and the UI doesn't validate that combination today.cskey is not yet supported by the v2rayN fork'sBaseFmt.cs, so links carryingcs=interop with v2rayN only once the same key is added there.🤖 Generated with Claude Code