Closed
Conversation
Contributor
|
@jenny-s51 would you also update the url in the react-docs/patternfly-a11y.config.js (line 69) so that it is testing the table-deprecated, not table-legacy url? Thanks! |
jenny-s51
force-pushed
the
iss8005
branch
2 times, most recently
from
89563c6 to
aefa293
Compare
Collaborator
|
Preview: https://patternfly-react-pr-8843.surge.sh A11y report: https://patternfly-react-pr-8843-a11y.surge.sh |
jenny-s51
force-pushed
the
iss8005
branch
5 times, most recently
from
99fc8f9 to
8b01c52
Compare
fix more paths, update config files fix more ts errors more TS errors fix paths to reference local dirs revert type cast include components path changes to examples wip more updates fix build errors update actionscolumn fix some more ts errors revert/update a whole bunch of file paths more paths update paths fix th and td th remove exports revert index.ts change and delete container files clean up files fix a11y config fix build errors fix more errors revert try fix circular dep error revert try fixing circular dep error fix path errors more errors add missing types fix build dist errors try fixing replace error delete composable examples fix conflicts fix deprecated dropdown refs try fixing build errors fix even more issues generate build error fix tests!!! try fixing circular dependencies and some demos fix errors in demo app circular dependencies fix imports to make tests pass fix more imports fix rowtype error fix circular deps tests
5 tasks
Contributor
Author
|
Closing in favor of #8892 . After discussion with @nicolethoen we came to the conclusion that due to these circular dependencies in the build, we needed to take a different approach to the table deprecation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What: Closes #8005
Additional issues: #8754