Conversation
|
Preview: https://patternfly-react-pr-8754.surge.sh A11y report: https://patternfly-react-pr-8754-a11y.surge.sh |
jenny-s51
force-pushed
the
renameComposableExamples
branch
2 times, most recently
from
7181fe4 to
d9871ca
Compare
jenny-s51
force-pushed
the
renameComposableExamples
branch
from
d9871ca to
3dc50b2
Compare
nicolethoen
left a comment
nicolethoen
left a comment
There was a problem hiding this comment.
Looks like a duplicate id 'untitled-example' is being used a couple times in the (formerly) composable table docs.
| ## Table examples | ||
|
|
||
| The `TableComposable` component differs from the regular `Table` component, in that it allows you to compose the table by nesting the relevant `Thead`, `Tbody`, `Tr`, `Th` and `Td` components within it. For a less declarative and more implicit approach, use the `Table` component instead. | ||
| This `TableComposable` component differs from the deprecated `Table` component, in that it allows you to compose the table by nesting the relevant `Thead`, `Tbody`, `Tr`, `Th` and `Td` components within it. For a less declarative and more implicit approach, use the `Table` component instead. |
There was a problem hiding this comment.
is it still accurate to say "This TableComposable component" rather than "This Table component"? The general bulleted notes below reference the Tablecomposable, too.
There was a problem hiding this comment.
@nicolethoen I left these remaining TableComposable references as-is because the <TableComposable /> component itself has not yet been renamed in this PR, but will be as part of #8843 . Using Table here would still be referencing the legacy variant.
Once #8843 is ready for review it will be using all the appropriate references!
jenny-s51
left a comment
jenny-s51
left a comment
There was a problem hiding this comment.
Thank you @nicolethoen - investigating the duplicate ID issue...
| ## Table examples | ||
|
|
||
| The `TableComposable` component differs from the regular `Table` component, in that it allows you to compose the table by nesting the relevant `Thead`, `Tbody`, `Tr`, `Th` and `Td` components within it. For a less declarative and more implicit approach, use the `Table` component instead. | ||
| This `TableComposable` component differs from the deprecated `Table` component, in that it allows you to compose the table by nesting the relevant `Thead`, `Tbody`, `Tr`, `Th` and `Td` components within it. For a less declarative and more implicit approach, use the `Table` component instead. |
There was a problem hiding this comment.
@nicolethoen I left these remaining TableComposable references as-is because the <TableComposable /> component itself has not yet been renamed in this PR, but will be as part of #8843 . Using Table here would still be referencing the legacy variant.
Once #8843 is ready for review it will be using all the appropriate references!
tlabaj
left a comment
tlabaj
left a comment
There was a problem hiding this comment.
LGTM! Just needs a rebase.
delete examples from legacy dir add todo bump rename TableComposable demos and examples fix filename revert md references for now fix name fix a11y config test update paths revert fix duplicate id revert path update remove whitespace
jenny-s51
force-pushed
the
renameComposableExamples
branch
from
3cd46c9 to
da88256
Compare
|
Your changes have been released in:
Thanks for your contribution! 🎉 |
4 participants
What: Closes #8749
Additional issues: Towards #8005.