-
Notifications
You must be signed in to change notification settings - Fork 6
Metadata query params #35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
dc78506
465b0b2
1c7aec7
8abf39d
76d31d4
f5e7896
30d59fa
6dcb486
8c8373a
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,2 +1,3 @@ | ||
| require: '@babel/register' | ||
| recursive: true | ||
| timeout: '10000' |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| 10.24.1 |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -5,6 +5,13 @@ All notable changes to this project will be documented in this file. | |
| The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), | ||
| and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html). | ||
|
|
||
| ## [1.9.0] - 2021-08-17 | ||
|
|
||
| ### Added | ||
|
|
||
| - Add support for querying Orders by `metadata` | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can you add the new parameter for ETH here too? |
||
| - Added `transaction_value_eth_gwei` as an alternative way to compute transaction level emissions for ethereum | ||
|
|
||
| ## [1.8.0] - 2021-07-20 | ||
|
|
||
| ### Added | ||
|
|
||
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -6,7 +6,7 @@ | |
| */ | ||
|
|
||
| import superagent from 'superagent'; | ||
| import querystring from 'querystring'; | ||
| import querystring from 'query-string'; | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. there are 2 changes in this file that fix support for deep objects. This is the first and it swaps out these two very similar libraries because the original one did not encode the urls correctly
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This answers my other question, thanks! |
||
|
|
||
| class ApiClient { | ||
| constructor() { | ||
|
|
@@ -60,6 +60,9 @@ class ApiClient { | |
| if (param instanceof Date) { | ||
| return param.toJSON(); | ||
| } | ||
| if (param instanceof Object) { | ||
| return param; | ||
|
Comment on lines
+63
to
+64
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. object query params will be encoded correctly by the library so they must be returned as is. Otherwise |
||
| } | ||
|
|
||
| return param.toString(); | ||
| } | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this will slow down CI but reduce the amount of "collisions" we may see due to the same tests running on the same endpoints in parallel. Considering we don't run CI on these projects very frequently, I feel the stability is worth the extra 2 minutes until we change up the test suite to not hit the real API