Metadata query params #35
Conversation
| strategy: | ||
| matrix: | ||
| node: ['10', '12', '14', '16'] | ||
| max-parallel: 1 |
There was a problem hiding this comment.
this will slow down CI but reduce the amount of "collisions" we may see due to the same tests running on the same endpoints in parallel. Considering we don't run CI on these projects very frequently, I feel the stability is worth the extra 2 minutes until we change up the test suite to not hit the real API
package.json
Outdated
| "build": "babel src -d dist", | ||
| "prepack": "npm run build", | ||
| "test": "mocha" | ||
| "test": "mocha --timeout 10000" |
There was a problem hiding this comment.
some specs run for longer than the default timeout so this gives us room for error
There was a problem hiding this comment.
This is redundant with the .mocharc.yml setting, I would remove from here.
|
|
||
| import superagent from 'superagent'; | ||
| import querystring from 'querystring'; | ||
| import querystring from 'query-string'; |
There was a problem hiding this comment.
there are 2 changes in this file that fix support for deep objects. This is the first and it swaps out these two very similar libraries because the original one did not encode the urls correctly
There was a problem hiding this comment.
This answers my other question, thanks!
| if (param instanceof Object) { | ||
| return param; |
There was a problem hiding this comment.
object query params will be encoded correctly by the library so they must be returned as is. Otherwise toString is called on them and we get "Object"
pcothenet
left a comment
pcothenet
left a comment
There was a problem hiding this comment.
Minor change for mocha settings. The rest looks great!
|
|
||
| ### Added | ||
|
|
||
| - Add support for querying Orders by `metadata` |
There was a problem hiding this comment.
Can you add the new parameter for ETH here too?
mocha.opts
Outdated
| @@ -0,0 +1 @@ | |||
| --timeout 10000 | |||
There was a problem hiding this comment.
There is already a .mocharc.yml file in the repo (mocha.opts is deprecated). Let's move that there!
There was a problem hiding this comment.
something kept generating this file but I'll remove it and use the rc
package.json
Outdated
| "build": "babel src -d dist", | ||
| "prepack": "npm run build", | ||
| "test": "mocha" | ||
| "test": "mocha --timeout 10000" |
There was a problem hiding this comment.
This is redundant with the .mocharc.yml setting, I would remove from here.
|
|
||
| import superagent from 'superagent'; | ||
| import querystring from 'querystring'; | ||
| import querystring from 'query-string'; |
There was a problem hiding this comment.
This answers my other question, thanks!
What
Why
Clients want the ability to query orders via metadata.
SDK Release Checklist