Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
If a variable was deallocated at the end of one step and reallocated during the next call to
ReceiveBoundBufs
, it would appear toSetBounds
that theBndInfo
cache was not stale (since the field was allocated on subsequent calls toSetBounds
) even though the variable itself contained newly allocated memory. This is fixed by checking the value ofVariable::GetAllocationStatus()
inCheckSendBufferCacheForRebuild
andCheckReceiveBufferCacheForRebuild
against the value that is now store inBndInfo
.GetAllocationStatus()
returns zero if the variable is deallocated and the number of times the variable has been allocated over the simulation otherwise.This should not have any impact on codes that do not use sparse variables.
PR Checklist