-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MG performance upgrades #973
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be useful to better document the solver parameters and how to use the solver more generically. But overall this LGTM.
Agreed, but I am not sure that the dust has settled on the solver stuff yet. I mostly want to get these changes in now so the branch doesn't go stale. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple of clarifying questions, so feel free to merge when ready.
Otherwise, I second @Yurlungur comment on documentation ;)
PR Summary
This PR makes some changes to make things go faster, including:
PackDescriptor
s for boundary conditions generic using a map. At least in MG, re-creating pack descriptors every call was a significant performance hit.This breaks downstream codes that use a solver, since now solvers require a call to
AddSetupTasks
before callingAddTasks
.PR Checklist